Replace float64 and use int64 for feePerKB calculcation #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK. We can probably also replace this minimum threshold with something smaller so that lower fee, higher priority transactions can still enter the mempool while having lower fees, while still preventing outright spam. |
alexlyp
force-pushed
the
ayp_nofeefloats
branch
from
95db6ef
to
ffc8e17
Compare
|
This looks good and was fine in my testing. |
|
tACK, mainnet node seems happy with this. |
Change calcMinRequiredTxRelay fee to take fee/kb as an arg This lets us to always compare int fees to fees and not have to calculate the tx's fee/kb just to compare to the threshold
alexlyp
force-pushed
the
ayp_nofeefloats
branch
from
ffc8e17
to
a5ca12f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.