addrmgr: skip never-successful addresses #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
requested changes
Jun 23, 2018
addrmgr/knownaddress.go
Outdated
| @@ -95,7 +95,7 @@ func (ka *KnownAddress) isBad() bool { | |||
| } | |||
|
|
|||
| // Never succeeded? | |||
| if ka.lastsuccess.IsZero() && ka.attempts >= numRetries { | |||
| if ka.lastsuccess.IsZero() || ka.attempts >= numRetries { | |||
There was a problem hiding this comment.
Will need to review all the surrounding code to be sure, but this doesn't look right to me at first glance. An address should not be marked bad before it's had a few tries (numRetries in this case) to succeed.
With this change, it seems like an address will be marked bad when lastsuccess is zero, which should always happen before the first connection has been made.
A node that has never been successfully connected should not be announced. Also, change maxFailures from 10 to a more conservative 5.
|
The AddressCache API is used by dcrd in server.go to reply to GetAddr requests. Now dcrd will not share nodes that itself has never connected to. |
When a peer sends an addr message, use the same time for each address sent. This saves up to wire.MaxAddrPerMsg-1 syscalls.
davecgh
approved these changes
Jun 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A node that has never been successfully connected should not be
announced.