Add GetStakeDifficultyResult to dcrjson so getstakedifficulty command can return more #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // GetStakeDifficultyResult models the data returned from the | ||
| // getstakedifficulty command. | ||
| type GetStakeDifficultyResult struct { | ||
| CurrentStakeDifficulty float64 `json:"currentstakediff"` |
There was a problem hiding this comment.
Maybe just make these "Current" and "Next", the user should know they're a response to the original command
|
rpc help needs regen. edit: nvm. was thinking this was wallet. dcrd creates the help dynamically. |
alexlyp
force-pushed
the
ayp_getstakediff
branch
from
de22d5a
to
f3ceb89
Compare
|
Squash and OK to merge |
alexlyp
force-pushed
the
ayp_getstakediff
branch
from
f3ceb89
to
8207e4d
Compare
|
This PR was merged in and only marked as closed rather than merged since github doesn't offer that useful and obvious option to mark it as such manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now instead of the getstakedifficulty returning just the current blockheader's sbits (current stake difficulty) it will also return the calculated stake difficulty of the next block. These values will typically be the same, but when the next block is a stake diff readjust users will see what the upcoming stake diff will be.