build: Refine build module support. #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions and associated tests are being removed because nothing depends on them and they end up creating a dependency on blockchain/stake package, which is not desirable.
This further refines the modules to add the following new modules instead of depending on the entire dcrd module: - github.com/decred/dcrd/dcrjson@v1.0.0 - github.com/decred/dcrd/blockchain@v1.0.0 - github.com/decred/dcrd/blockchain/stake@v1.0.0 - github.com/decred/dcrd/gcs@v1.0.0 - github.com/decred/dcrd/mining@v1.0.0 - github.com/decred/dcrd/mempool@v1.0.0 - github.com/decred/dcrd/peer@v1.0.0 - github.com/decred/dcrd/rpcclient@v1.0.0 Also, it ensures modules that rely on other modules within the repo are provided replacements to the latest repo code to ensure builds against master and continuous integration use the latest code. - github.com/decred/dcrd/addrmgr - github.com/decred/dcrd/blockchain - github.com/decred/dcrd/blockchain/stake - github.com/decred/dcrd/chaincfg - github.com/decred/dcrd/connmgr - github.com/decred/dcrd/database - github.com/decred/dcrd/dcrec/secp256k1 - github.com/decred/dcrd/dcrjson - github.com/decred/dcrd/dcrutil - github.com/decred/dcrd/gcs - github.com/decred/dcrd/hdkeychain - github.com/decred/dcrd/mempool - github.com/decred/dcrd/mining - github.com/decred/dcrd/peer - github.com/decred/dcrd/rpcclient - github.com/decred/dcrd/txscript - github.com/decred/dcrd/wire
|
github will only let me comment, not review. without javascript. OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This further refines the modules to add the following new modules instead of depending on the entire
dcrdmodule:Also, it ensures modules that rely on other modules within the repo are provided replacements to the latest repo code to ensure builds against master and continuous integration use the latest code.