multi: Include additional fields on RPC tx results. #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
multi_rpc_include_additional_fields
branch
3 times, most recently
from
3a7769a
to
c45ca59
Compare
dnldd
approved these changes
Sep 10, 2018
matheusd
approved these changes
Sep 10, 2018
jrick
approved these changes
Sep 10, 2018
This modifies the results provided by the getrawtransaction and searchrawtransactions RPCs to make them consistent with each other. In particular, it adds the transaction expiry, block height, and block index fields to the searchrawtransactions result and ensures that both omit the block height when it is zero so that it is not included in the results for mempool transactions. Since populating the block index requires additional details to be stored to the transaction index to efficiently provide, only the infrastructure is added and the value is left as the default for now, which means it will be omitted and therefore not change the visible behavior. Finally, it also updates the RPC server help to provide consistent descriptions for the fields and also updates the JSON-RPC documentation.
davecgh
force-pushed
the
multi_rpc_include_additional_fields
branch
from
c45ca59
to
5db19dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the results provided by the
getrawtransactionandsearchrawtransactionsRPCs to make them consistent with each other.In particular, it adds the transaction expiry, block height, and block index fields to the
searchrawtransactionsresult and ensures that both omit the block height when it is zero so that it is not included in the results for mempool transactions.Since populating the block index requires additional details to be stored to the transaction index to efficiently provide, only the infrastructure is added and the value is left as the default for now, which means it will be omitted and therefore not change the visible behavior.
Finally, it also updates the RPC server help to provide consistent descriptions for the fields and also updates the JSON-RPC documentation.