rpcserver: Adds ability to allow alternative dns names for TLS. #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A quick note that this is failing CI due to a duplicate test definition. |
logicminds
force-pushed
the
altdnsnames
branch
3 times, most recently
from
5cf14a9
to
1243a37
Compare
davecgh
requested changes
Oct 9, 2018
rpcserver_test.go
Outdated
| @@ -106,6 +110,12 @@ var primaryHarness *rpctest.Harness | |||
| func TestMain(m *testing.M) { | |||
| var err error | |||
|
|
|||
| // Parse the -test.* flags before removing them from the command line | |||
| // arguments list, which we do to allow go-flags to succeed. | |||
| // See config_test.rb for more info | |||
rpcserver_test.go
Outdated
| @@ -115,7 +125,6 @@ func TestMain(m *testing.M) { | |||
| fmt.Println("unable to create primary harness: ", err) | |||
| os.Exit(1) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Please don't remove this new line.
config_test.go
Outdated
| // arguments list, which we do to allow go-flags to succeed. | ||
| flag.Parse() | ||
| os.Args = os.Args[:1] | ||
| // Run the tests now that the testing package flags have been parsed. |
rpcserver_test.go
Outdated
| defer os.Remove(certfile.Name()) | ||
| err := genCertPair(certfile.Name(), keyfile.Name(), hostnames) | ||
| if err != nil { | ||
| t.Fatalf("certifcate was not created correctly") |
There was a problem hiding this comment.
Would be helpful to include the error here, so if it fails, we'll know why.
rpcserver_test.go
Outdated
| @@ -165,3 +174,36 @@ func TestRpcServer(t *testing.T) { | |||
| currentTestNum++ | |||
| } | |||
| } | |||
|
|
|||
| func TestCertCreationWithHosts(t *testing.T) { | |||
| certfile, _ := ioutil.TempFile("", "certfile") | |||
There was a problem hiding this comment.
I'd suggest checking errors using t.Fatalf to display them and fail the test if non nil. Otherwise, it will be difficulty to figure out why the test is failing.
Same goes for the rest.
* Adds AltDNSNames config for passing additional hostnames to the
TLS certificate generate method. Without this change
there is no way to pass in alternative dns names for the rpc
server.
* Additionally this commit allows the user to set 'DCRD_ALT_DNSNAMES'
as an environment variable when starting dcrd. This is useful for
docker and other app runtimes that require apps to be 12 factor.
logicminds
force-pushed
the
altdnsnames
branch
from
1243a37
to
35a9e5d
Compare
davecgh
approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds AltDNSNames config for passing additional hostnames to the
TLS certificate generate method. Without this change
there is no way to pass in alternative dns names for the rpc
server.
Additionally this commit allows the user to set 'DCRD_ALT_DNSNAMES'
as an environment variable when starting dcrd. This is useful for
docker and other app runtimes that require apps to be 12 factor.