multi: Latest consensus active from simnet genesis. #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
multi_simnet_latest_consensus_changes_active_from_genesis
branch
2 times, most recently
from
fb25fef
to
8e6cd7c
Compare
|
I'm confused, why aren't the modules being given new versions? Those versions are already published, and we can't change them now (and more practically, it breaks Go's build cache). |
|
@jrick The versions are not yet published. |
dnldd
approved these changes
Oct 10, 2018
davecgh
force-pushed
the
multi_simnet_latest_consensus_changes_active_from_genesis
branch
from
8e6cd7c
to
af5131a
Compare
alexlyp
approved these changes
Oct 10, 2018
This modifies simnet to include the latest consensus changes that have been successfully voted into mainnet to date starting from its genesis block. This means it is no longer necessary to vote those changes in to simnet first before making use of them. The changes entail removing the deployment entries for those votes, updating the mining templates to start from version 5, which matches the current mainnet version, and modifying the various sections in blockchain which make decisions accordingly. The chaincfg and blockchain modules are affected, but since their version has already been bumped since their last release tags, they are not bumped again.
davecgh
force-pushed
the
multi_simnet_latest_consensus_changes_active_from_genesis
branch
from
af5131a
to
15f7f61
Compare
davecgh
deleted the
multi_simnet_latest_consensus_changes_active_from_genesis
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires PRs #1480 and #1481.
This modifies
simnetto include the latest consensus changes that have been successfully voted into mainnet to date starting from its genesis block. This means it is no longer necessary to vote those changes in tosimnetfirst before making use of them.The changes entail removing the deployment entries for those votes, updating the mining templates to start from version 5, which matches the current
mainnetversion, and modifying the various sections inblockchainwhich make decisions accordingly.The
chaincfgandblockchainmodules are affected, but since their version has already been bumped since their last release tags, they are not bumped again.