mempool: reduce lock contention #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we make the title and description of the commit the same as upstream and just add the commit which it was derived from to the description? "Recreated 907..." doesn't really let anyone know what the purpose of this commit is without having to go dig through btcsuite/btcd as well. |
|
good point. i'll do so now |
alexlyp
changed the title
|
Please make the description of the commit reflect the problem and changes |
Previously mp.lastUpdated = time.Now() needed a lock for acess. With the use of atomic.StoreInt64, it allows us to remove the lock in LastUpdated which now can be run in mempool. Recreated 907152c commit from btcd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreated 907152c commit from btcd
Previously mp.lastUpdated = time.Now() needed to be locked for access. With the use of atomic.StoreInt64, it allows us to remove the now unneeded lock in LastUpdated which can run without racing in mempool.