secp256k1/ecdsa: update error types. #2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
force-pushed
the
update_ecdsa_error_types
branch
from
de056dc to
2dc3946
Compare
davecgh
requested changes
Dec 15, 2020
There was a problem hiding this comment.
Thanks for the PR. Looks good overall. I only noticed on nitpick that is identified inline.
However, this is changing the public API in a non-backwards compatible way. That means a major module version bump is required. Similar to previous cases such as for gcs, please follow the standard practice for a major version bump to v4 via a separate PR.
This updates the ECDSA error types to leverage go 1.13 errors.Is/As functionality as well as conform to the error infrastructure best practices.
dnldd
force-pushed
the
update_ecdsa_error_types
branch
from
2dc3946 to
d31c8d3
Compare
davecgh
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the ECDSA error types to leverage go 1.13 errors.Is/As functionality as well as conform to the error infrastructure best practices outline in #2181.