chaincfg: Register networks instead of hard coding. #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies the chaincfg package to register the default network params via the init function instead of manually hard coding their data into the maps. This is less error prone when adding new default networks. A new function named mustRegister has been introduced that panics if there are any errors when registering the network that the new code makes use of and appropriate tests have been added.
|
OK |
Upstream commit c7e5d56.
davecgh
force-pushed
the
merge_chaincfg_register
branch
from
8d7a320
to
d6ac2f0
Compare
|
tACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream commit c7e5d56.