[release-v1.6] server: Only send fast block anns to full nodes. #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fast block announcements were added a few years ago as a way to increase the propagation speed of new blocks that extend the main chain through the network to significantly reduce voting latency as well as how quickly proof-of-work miners discover new blocks. This is desirable behavior, however, it should only apply to full nodes since only they are equipped to deal with the fast announcements. As a case in point, header commitments and committed block filters can pose a problem for lightweight clients that rely on them in the case of fast block announcements because lightweight clients tend to request the filters as soon as they learn about the new blocks and those filters have not been created yet when fast block announcements are sent. Since there is network latency involved in the request process, the result is that sometimes the filters are available by the time the requests from lightweight clients are received and sometimes they are not. In order to help prevent the aforementioned case, and other similar ones, this modifies the code that deals with block announcements to only send fast block announcements to peers that advertise themselves as full nodes instead of all nodes and separates out the block announcement logic slightly to make future enhancements easier in the process. It also modifies the filtering of duplicate block announcements to work on a per peer basis since not all peers receive the fast block announcement now.
jrick
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #2606 to the 1.6 release branch.