[release-v1.7] rpcserver: Update websocket ping timeout handling. #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, timeouts when responding to a websocket ping control message with a pong message cause the websocket client to be disconnected, but these types of failures are nearly always temporary network errors due to things such as congestion and thus should not result in disconnection. In order to make that the case, this modifies the websocket ping handler to ignore timeout network errors when attempting to respond with a pong and also takes this opportunity to increase the timeout to 5 seconds from 1 second to support multi-continent communication.
davecgh
force-pushed
the
rel17_rpcserver_ping_handler_timeout
branch
from
607ca9e
to
14958dd
Compare
jrick
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #2865 to the 1.7 release branch.