[release-v1.7] multi: Build and doco updates for Go 1.20. #3087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script `run_tests.sh` does not work if a go.work file is present in the project root. This is because when a `go.work` file is present, `go list -m` returns the names of all modules in the workspace rather than just the parent module in the root directory. Removing the `-m` flag fixes this.
This updates to the following Github Actions: - actions/setup-go@6edd440 #v3.5.0 - actions/checkout@ac59398 #v3.3.0
davecgh
force-pushed
the
rel17_multi_go_1_20
branch
3 times, most recently
from
3f01d93
to
4de046f
Compare
chappjc
approved these changes
Apr 7, 2023
|
I'm still working on making it build properly against the latest versions of Go and the linter/vet that works with them. The updates to various things are spread out over time, so having to find and cherry-pick the right ones.
I think that's only because these are all backports to an old release branch. On |
davecgh
force-pushed
the
rel17_multi_go_1_20
branch
2 times, most recently
from
925dc2a
to
e98da44
Compare
This modifies the entire repository to use the new formatting of doc comments in the upcoming Go 1.19 release. The primary motivating factors for this are: - Builds check that files are formatted per gofmt and that will no longer be true as of Go 1.19 without these changes - Separating all the updates into a single commit ensures these documentation only formatting changes do not clutter up diffs that actually change code For the most part, the changes are just the automated changes suggested by the Go 1.19 version of gofmt, but there are also a few cases where the comments were reworded a bit to play nicely with the new formatting requirements. For example, the new version of gofmt reformats and collapses nested lists where as the existing version does not. Thus, instances of nested lists have been changed to either eliminate them or use mixed markers which produce expect results.
This updates CI to test against Go 1.20 and removes the tests for Go 1.18 accordingly.
davecgh
force-pushed
the
rel17_multi_go_1_20
branch
from
e98da44
to
7aa0549
Compare
|
Alright, I've cherry-picked and backported everything for the 1.7 release branch to build with the latest versions of Go and pass all lint and vet checks now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #2976, #3021 and #3052 to the 1.7 release branch.