multi: Integrate mixpool and propagate p2p mixing messages #3208
Conversation
jrick
force-pushed
the
mixing_server
branch
3 times, most recently
from
14218d5 to
a379d96
Compare
jrick
force-pushed
the
mixing_server
branch
3 times, most recently
from
02673d2 to
fea21bd
Compare
jrick
changed the title
jrick
force-pushed
the
mixing_server
branch
13 times, most recently
from
4fda613 to
1fe24e6
Compare
internal/rpcserver/rpcwebsocket.go
Outdated
| wsc.blake256HaserMu.Unlock() | ||
| //hash := msg.Hash() | ||
|
|
||
| err = wsc.rpcServer.cfg.SyncMgr.SubmitMixMessage(msg) |
There was a problem hiding this comment.
Shouldn't this be returning all of the accepted messages (because orphans can be added) and then relaying them all?
There was a problem hiding this comment.
Probably.. but the ordering issues aren't so relevant to rpc clients who can/will send them in the proper order. I don't think I've ever seen dcrd reject a KE from a rpc-mode wallet because the PR was unknown. I intentionally also increased the time it takes to expire PRs out of dcrd's mixpool, so they would not be removed from underneath the wallet.
There was a problem hiding this comment.
Leaving unresolved for now. It's not a big issue for now and we can add it later.
internal/rpcserver/rpcwebsocket.go
Outdated
|
|
||
| wsc.rpcServer.cfg.ConnMgr.RelayMixMessages([]mixing.Message{msg}) | ||
|
|
||
| wsc.rpcServer.ntfnMgr.NotifyMixMessage(msg) |
There was a problem hiding this comment.
Similarly, this should be notifying of all accepted mix messages in the order they were accepted (which is what is returned from mixpool.AcceptMessage).
There was a problem hiding this comment.
Leaving unresolved for now. It's not a big issue for now and we can add it later.
There was a problem hiding this comment.
Looks good to go. I did some light simnet testing of the RPC server after the updates:
$ ./ctl -l | grep -E 'sendrawmix|mixpair'
getmixpairrequests
sendrawmixmessage "command" "message"
$ ./ctl sendrawmixmessage
sendrawmixmessage command: wrong number of params (expected 2, received 1) (ErrNumParams)
Usage:
sendrawmixmessage "command" "message"
$ ./ctl sendrawmixmessage foo 0a
-8: Unrecognized mixing message wire command string "foo"
$ ./ctl getmixpairrequests
[]Feel free to squash it down and we can get it merged. 🎉
This commit adds the mixing message pool to the server and listens for all peer-to-peer mixing messages broadcast on the network. If these messages are able to be accepted to the mixpool, they are relayed to other peers through the inventory system, and notified to RPC clients. This commit also also adds support for publishing and receiving mix messages over JSON-RPC for non-SPV wallet clients.
davecgh
added
the
rpc server api change
This commit adds the mixing message pool to the server and listens for all
peer-to-peer mixing messages broadcast on the network. If these messages are
able to be accepted to the mixpool, they are relayed to other peers through
the inventory system, and notified to RPC clients.
This commit also also adds support for publishing and receiving mix messages
over JSON-RPC for non-SPV wallet clients.
Requires #3207.
Requires #3082.