wire: Remove PR hashes from (get)initstate #3244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts all of the initstate changes made in b9d8d49. The limit of 100 was too too low to be useful and cranking this value up was not a proper solution either. It also only synced pair request messages, which would cause mid-run mixes to leave stale PRs around in the mixpool until they expired. This is handled better in newer mixpool code by requesting unknown pair request messages when they are seen in a key exchange. The mixpool records the KE as an orphan and will process it after all missing PRs have been requested and processed.
davecgh
approved these changes
May 6, 2024
davecgh
added
the
wire protocol change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts all of the initstate changes made in
b9d8d49.
The limit of 100 was too too low to be useful and cranking this value up was not a proper solution either. It also only synced pair request messages, which would cause mid-run mixes to leave stale PRs around in the mixpool until they expired.
This is handled better in newer mixpool code by requesting unknown pair request messages when they are seen in a key exchange. The mixpool records the KE as an orphan and will process it after all missing PRs have been requested and processed.