wire: Add MsgMixFactoredPoly #3247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
commented
May 7, 2024
jrick
force-pushed
the
factoredpoly
branch
2 times, most recently
from
b03872e
to
086a61b
Compare
This message contains the result of the factored slot reservation polynomial. Clients that are capable of solving this (with optionally-installed csppsolver) will publish the result for clients that don't.
davecgh
approved these changes
May 11, 2024
| // message fields excluding the signature. This is the data committed to when | ||
| // the message is signed. | ||
| func (msg *MsgMixFactoredPoly) WriteSignedData(h hash.Hash) { | ||
| WriteVarString(h, MixVersion, CmdMixFactoredPoly+"-sig") |
There was a problem hiding this comment.
Not going to hold up this PR since WriteVarString doesn't actually use the parameter currently anyway, but I have noticed in all of these that they're arguably misusing the protocol version. It is generally supposed to be passed in so that it ultimately is the negotiated protocol version. The intention of the parameter is that some future protocol version might change the semantics and thus it would need to selectively choose based on the negotiated version.
That said, I mentioned arguably previously because I guess you could argue that given this is a signature, you might want it to be stable. However, I don't believe there is anything long term that would need it to be stable in such a scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This message contains the result of the factored slot reservation polynomial. Clients that are capable of solving this (with optionally-installed csppsolver) will publish the result for clients that don't.