Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wire: Zero out secrets signature for commitment hash #3248

Merged
merged 1 commit into from
May 9, 2024

Conversation

jrick
Copy link
Member

@jrick jrick commented May 8, 2024

The signature changes depending on the published previous RS message hashes, and therefore cannot be used to create the commitment hash covering the actual secrets being published by the message.

The signature changes depending on the published previous RS message hashes,
and therefore cannot be used to create the commitment hash covering the actual
secrets being published by the message.
@jrick
Copy link
Member Author

jrick commented May 8, 2024

Alternatively we could move this method completely outside of the wire package. It could reasonably live as a function in the mixing module instead.

@davecgh
Copy link
Member

davecgh commented May 9, 2024

I'll go ahead and approve and merge it since the change is needed anyway.

I'm fine with it living in the mixing module instead too. I think I've mentioned before that I generally think wire ideally should just be handling the serialization/deserialization bits anyway and all types of commitments and the like handled elsewhere, but in an effort to get the decentralized mixing landed, it's fine to have things not be in the most ideal locations for now.

@davecgh davecgh merged commit d4ab4f5 into decred:master May 9, 2024
2 checks passed
@davecgh davecgh added this to the 1.9.0 milestone May 9, 2024
@davecgh davecgh added the wire protocol change Discussion and pull requests regarding items that require changes to the wire protocol. label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wire protocol change Discussion and pull requests regarding items that require changes to the wire protocol.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants