multi: Remove reject wire protocol support. #3254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
added
the
wire protocol change
davecgh
force-pushed
the
multi_remove_reject_wire_protocol_support
branch
from
2816bf1
to
5c616aa
Compare
jrick
approved these changes
May 10, 2024
This bumps the minimum required protocol version to the version that no longer supports the reject message now that a new consensus change has taken place and all older nodes that might use it are no longer able to follow the chain anyway.
This removes code for handling deprecated reject messages which are no longer supported by the network. Since removing the handler definition itself would be a major module version bump, it is not removed at this time and instead the deprecated comment is updated to clearly communicate that the underlying message is no longer valid and thus the handler will no longer ever be invoked.
This updates the mock connection used in the peer tests to close the underlying readers and writers when the connection is closed to more closely match the behavior of real connections when they are closed.
This bumps the minimum required protocol version for peers to the version that no longer supports the reject message now that a new consensus change has taken place and all older nodes that might use it are no longer able to follow the chain anyway. It also adds a test to ensure peers with older protocol versions are disconnected as intended.
This removes code for accepting reject messages which are no longer supported by the network. Since removing the type definition itself would be a major module version bump, it is not removed at this time and instead the ability to recognize the message is removed so that any attempts to read the message will result in a protocol error. The type and associated test code can be removed on a major module version bump.
davecgh
force-pushed
the
multi_remove_reject_wire_protocol_support
branch
from
5c616aa
to
ffa391d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the deprecation and code removal for the
rejectmessage as previously detailed by #2546.In particular, it consists of a series of commits that:
rejectmessage (v9)rejectmessage (v9)rejectmessagewirecode for acceptingrejectmessages which are no longer supported by the networkCloses #2546.