mixclient: Use newest (fewest-PR) KEs to form alt sessions #3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The alternate session forming only incrementally removes PRs from the currently considered PR set. Even if a PR by a responsive peer is known, if it was removed due to not passing the majority checks earlier, it will never be used by our peers during this epoch. With that in mind, we should only use the most recent KEs with the lowest referenced PR counts when trying to form an alternate session, as the additional PRs from earlier KEs will never be reconsidered by that KE's identity.
davecgh
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alternate session forming only incrementally removes PRs from the currently considered PR set. Even if a PR by a responsive peer is known, if it was removed due to not passing the majority checks earlier, it will never be used by our peers during this epoch. With that in mind, we should only use the most recent KEs with the lowest referenced PR counts when trying to form an alternate session, as the additional PRs from earlier KEs will never be reconsidered by that KE's identity.