eth/client: Replace gas estimates with hardcoded values #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff updates the eth swap contract by removing the original initiate function which only allows initiating one swap at a time and renaming initiateBatch to initiate. The gas savings from initiating a single swap using the old initiate function are negligible and removing it greatly simplifies the codebase.
There can be no variation in the execution path for initiating swaps, so there's no point in doing gas estimates.
|
I incorporated this change into #1248 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no variation in the execution path for initiating swaps, so there's no point in doing gas estimations. The gas estimation happens without any external calls, and on any updates to the geth code which would invalidate the hardcoded values, the harness tests will let us know.
This will come on top of #1262