app: switch to typescript #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change all files to typescript and enforce typing during builds. Shared types are defined in registry.ts.
buck54321
commented
Mar 19, 2022
Comment on lines
-1989
to
+2121
| this.candleChart.setCandles(cache, cfg) | ||
| this.candleChart.setCandles(cache, cfg, baseUnitInfo, quoteUnitInfo) |
There was a problem hiding this comment.
This seems to have been a bug.
Comment on lines
746
to
877
| if (baseWallet.available < mkt.cfg.lotsize) { | ||
| if (baseWallet.balance.available < mkt.cfg.lotsize) { |
There was a problem hiding this comment.
Seems to have also been a bug.
chappjc
reviewed
Mar 19, 2022
chappjc
reviewed
Mar 19, 2022
martonp
reviewed
Mar 20, 2022
There was a problem hiding this comment.
This is great! Will be much nicer to work on the UI from now on.
What do you think about turning strictNullChecks on? There will be many errors to fix.. I can give it a shot in another PR if you don't want to. I think it can be a pain sometimes, but it will make things a lot safer.
JoeGruffins
approved these changes
Mar 21, 2022
martonp
approved these changes
Mar 23, 2022
chappjc
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change all files to typescript and enforce typing during builds. Shared types are defined in registry.ts.