multi: support fiat conversion for assets #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukane-philemon
force-pushed
the
fiatconv
branch
3 times, most recently
from
bca8b89
to
ac32ba2
Compare
JoeGruffins
reviewed
Jun 17, 2022
buck54321
requested changes
Jun 19, 2022
|
No rush @ukane-philemon, just wanted to bump since the ball is in your court with current reviews, in case you missed. |
|
@chappjc, thanks. Will get them fixed. |
ukane-philemon
force-pushed
the
fiatconv
branch
2 times, most recently
from
b69de9d
to
8b805d3
Compare
|
Send Form: |
buck54321
requested changes
Jun 25, 2022
ukane-philemon
force-pushed
the
fiatconv
branch
2 times, most recently
from
21256d6
to
2d94c2f
Compare
|
@buck54321, I've made changes and updated the UI display in my first comment. |
buck54321
requested changes
Jul 3, 2022
ukane-philemon
force-pushed
the
fiatconv
branch
2 times, most recently
from
a09fd81
to
6937978
Compare
buck54321
requested changes
Jul 5, 2022
Comment on lines
+137
to
+123
| if asset.Wallet == nil { | ||
| // we don't want to fetch rates for assets with no wallet. | ||
| continue | ||
| } |
There was a problem hiding this comment.
We may end up wanting to get more sophisticated with this. One place the client might benefit from asset conversions is in the registration fee asset selection, which would require us to get rates for non-wallet assets.
Nothing to do here, just looking forward.
|
update send form UI: |
JoeGruffins
reviewed
Jul 6, 2022
There was a problem hiding this comment.
Currently unable to load the webserver on simnet with a panic:
panic
2022/07/06 11:11:25 http: panic serving 127.0.0.1:34718: runtime error: slice bounds out of range [-1:]
goroutine 2172 [running]:
net/http.(*conn).serve.func1()
/usr/lib/go/src/net/http/server.go:1825 +0xbf
panic({0x141c1a0, 0xc001cae2e8})
/usr/lib/go/src/runtime/panic.go:844 +0x258
github.com/go-chi/chi/v5/middleware.prettyStack.decorateFuncCallLine({}, {0xc000862e5b, 0x1d}, 0x4?, 0x8)
/home/joe/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.1/middleware/recoverer.go:130 +0x545
github.com/go-chi/chi/v5/middleware.prettyStack.decorateLine({}, {0xc000862e5b?, 0xc00027a800?}, 0x90?, 0x1?)
/home/joe/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.1/middleware/recoverer.go:106 +0x15d
github.com/go-chi/chi/v5/middleware.prettyStack.parse({}, {0xc001cfa000, 0xaf4, 0xc00222b1d8?}, {0x12fc920, 0x21a0700})
/home/joe/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.1/middleware/recoverer.go:89 +0x4e5
github.com/go-chi/chi/v5/middleware.PrintPrettyStack({0x12fc920, 0x21a0700})
/home/joe/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.1/middleware/recoverer.go:46 +0x45
github.com/go-chi/chi/v5/middleware.(*defaultLogEntry).Panic(0x3c?, {0x12fc920?, 0x21a0700?}, {0x8?, 0x0?, 0x0?})
/home/joe/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.1/middleware/logger.go:165 +0x29
github.com/go-chi/chi/v5/middleware.Recoverer.func1.1()
/home/joe/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.1/middleware/recoverer.go:28 +0xcc
panic({0x12fc920, 0x21a0700})
/usr/lib/go/src/runtime/panic.go:838 +0x207
decred.org/dcrdex/client/core.(*Core).saveDisabledRateSources(0xc0003d96c0)
/home/joe/git/dcrdex/client/core/core.go:7689 +0x19a
decred.org/dcrdex/client/core.(*Core).fiatConversions(0xc0003d96c0)
/home/joe/git/dcrdex/client/core/core.go:7602 +0x1a5
decred.org/dcrdex/client/core.(*Core).User(0xc0003d96c0)
/home/joe/git/dcrdex/client/core/core.go:1749 +0x53
decred.org/dcrdex/client/webserver.(*WebServer).authMiddleware.func1({0x7f10c05291c8, 0xc001c991c0}, 0xc00160b100)
/home/joe/git/dcrdex/client/webserver/middleware.go:43 +0x99
net/http.HandlerFunc.ServeHTTP(0x10?, {0x7f10c05291c8?, 0xc001c991c0?}, 0x4167b9?)
/usr/lib/go/src/net/http/server.go:2084 +0x2f
github.com/go-chi/chi/v5/middleware.Recoverer.func1({0x7f10c05291c8?, 0xc001c991c0?}, 0xc0016278c0?)
/home/joe/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.1/middleware/recoverer.go:37 +0x83
net/http.HandlerFunc.ServeHTTP(0x13e86e0?, {0x7f10c05291c8?, 0xc001c991c0?}, 0xe?)
/usr/lib/go/src/net/http/server.go:2084 +0x2f
decred.org/dcrdex/client/webserver.(*WebServer).securityMiddleware.func1({0x7f10c05291c8, 0xc001c991c0}, 0xc001ce8400?)
/home/joe/git/dcrdex/client/webserver/middleware.go:34 +0x4ed
net/http.HandlerFunc.ServeHTTP(0xc00160b000?, {0x7f10c05291c8?, 0xc001c991c0?}, 0x203000?)
/usr/lib/go/src/net/http/server.go:2084 +0x2f
github.com/go-chi/chi/v5/middleware.RequestLogger.func1.1({0x197e468, 0xc001cb0380}, 0xc00160b000)
/home/joe/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.1/middleware/logger.go:57 +0x3aa
net/http.HandlerFunc.ServeHTTP(0x197ef78?, {0x197e468?, 0xc001cb0380?}, 0x21a0410?)
/usr/lib/go/src/net/http/server.go:2084 +0x2f
github.com/go-chi/chi/v5.(*Mux).ServeHTTP(0xc0001a8780, {0x197e468, 0xc001cb0380}, 0xc00160af00)
/home/joe/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.1/mux.go:88 +0x442
net/http.serverHandler.ServeHTTP({0xc001ce8360?}, {0x197e468, 0xc001cb0380}, 0xc00160af00)
/usr/lib/go/src/net/http/server.go:2916 +0x43b
net/http.(*conn).serve(0xc001cbe140, {0x197f020, 0xc000140a50})
/usr/lib/go/src/net/http/server.go:1966 +0x5d7
created by net/http.(*Server).Serve
/usr/lib/go/src/net/http/server.go:3071 +0x4db
And after that I am unable to stop dexc.
chappjc
requested changes
Jul 8, 2022
|
We might need to revise the tooltip infomation. |
buck54321
requested changes
Jul 11, 2022
maybe the fiat rate was not available at the time you prepared the order. A refresh requests the rates directly from the client-server via |
ukane-philemon
force-pushed
the
fiatconv
branch
2 times, most recently
from
e53327b
to
06243a5
Compare
chappjc
requested changes
Jul 12, 2022
ukane-philemon
force-pushed
the
fiatconv
branch
4 times, most recently
from
06c96ca
to
cd7a05a
Compare
|
Feel free to squash before rebasing to make resolution simpler. i.e. |
chappjc
requested changes
Jul 14, 2022
This enables the conversion of assets value to fiat equivalent. - Modify wallets page to display fiat value for asset if asset exchange rate is available. - Modify settings page to display available exchange rate source. - Modify order verify form to display value for base and quote assets. - Add new enpoint to support enabling and disabling of exchange rate source. - Add tests to cover exchange rate fetching.
chappjc
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
Working well. Good stuff! A few minor nits remaining. Will wait on @buck54321 for a closer look at frontend bits.
buck54321
requested changes
Jul 22, 2022
|
@buck54321, @chappjc, @JoeGruffins thanks for the reviews and making this look shiny :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the conversion of assets value to fiat equivalent. Configuring fiat conversion is UI only. closes #1579
Wallet view
Market view
Withdraw/Send Form view
Exchange rate source settings view
