dex/encode: allow data longer than 65535 bytes #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
force-pushed
the
larger-blobs
branch
2 times, most recently
from
3b53dc5
to
43d9aef
Compare
buck54321
reviewed
May 25, 2022
Comment on lines
+194
to
+197
| // cannot switch to uint32 at 65535 itself since it is possible | ||
| // there is data of exactly that length already stored using just | ||
| // two bytes to encode the length. Thus, the decoder should inspect |
There was a problem hiding this comment.
Ah crap. It it wasn't for this, we could just us the varint stuff from wire.
Retrofit the blob encoding and decoding to allow byte slices up to 0x00fe_ffff (16711679) long. The decoding scheme detects a uint32 length when the top two bytes decoded as big endian uint16 indicate a value less than 255.
buck54321
approved these changes
May 25, 2022
|
Well, good to go then, although despite my best efforts on this one, I still feel nervous that there's a gotcha somewhere despite it testing well. We have a bit until 0.5 so I guess we'll just see how this does with more use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relating to the issue hit in #1105 (comment), where the counter tx data was too large on account of the tx having many funding coins.
This is a bit of a cludge, but it seems to be working, so I figure we could discuss it.