client/asset/bch: native Bitcoin Cash SPV wallet #1635
Conversation
|
For gcash/neutrino, I think lightninglabs/neutrino#247 would be good too. It properly resolves the "always timeout" issue when publishing a transaction, where my previous commit to resolve that missed the mark. |
Done |
buck54321
force-pushed
the
bchspv
branch
2 times, most recently
from
2c3b370
to
f948c02
Compare
buck54321
force-pushed
the
bchspv
branch
2 times, most recently
from
fd1327c
to
b08dddd
Compare
client/asset/bch/bch.go
Outdated
| // only used for wallets with WalletDefinition.Seeded = true. | ||
| func (d *Driver) Exists(walletType, dataDir string, settings map[string]string, net dex.Network) (bool, error) { | ||
| if walletType != walletTypeSPV { | ||
| return false, fmt.Errorf("no Bitcoin wallet of type %q available", walletType) |
There was a problem hiding this comment.
Maybe intended, but says "Bitcoin".
client/asset/bch/spv.go
Outdated
| // AddPeers: addPeers, | ||
| ConnectPeers: connectPeers, | ||
| // // WARNING: PublishTransaction currently uses the entire duration | ||
| // // because if an external bug, but even if the resolved, a typical |
There was a problem hiding this comment.
even if the bug is resolved
client/asset/bch/spv.go
Outdated
| // Depending on the network, we add some addpeers or a connect peer. On | ||
| // regtest, if the peers haven't been explicitly set, add the simnet harness | ||
| // alpha node as an additional peer so we don't have to type it in. On | ||
| // mainet and testnet3, add a known reliable persistent peer to be used in |
There was a problem hiding this comment.
Looks like testnet4 is used.
| case bchwire.TestNet, bchwire.SimNet: // plain "wire.TestNet" is regnet! | ||
| connectPeers = []string{"localhost:21577"} | ||
| } |
There was a problem hiding this comment.
I can't seem to get past "no peers" on testnet. I have a local node running and tried changing this to the port I set for it but still no peers. Any idea what I can try?
There was a problem hiding this comment.
The comment here I think is to indicate that there is some ambiguity between testnet 1 and simnet. As you indicated, we're using bchwire.TestNet4. I've now added a addPeers = []string{"localhost:28333"} for that case, and was able to sync with bchd --testnet4 running locally. For Bitcoin, we added a testnet btcd node at dex-test.ssgen.io. Maybe we'll want to do the same for bch eventually.
There was a problem hiding this comment.
Might be needed if cfilter peers are scarce. Hopefully not though
There was a problem hiding this comment.
Oh no, I was using -testnet instead of -testnet4. So... I should use testnet 4 right?
There was a problem hiding this comment.
Oh crap. We can't use testnet 4, can we?
There was a problem hiding this comment.
Pretty sure we sorted it out on Matrix, but we're on testnet4 so that's right. @JoeGruffins I guess the confusion for you was that you need bchd installed locally to have a node serving cfilters since bitcoin-cash-node isn't able.
There was a problem hiding this comment.
Still not finding peers after running bchd. This definitely works for others on testnet?
There was a problem hiding this comment.
Still not finding peers after running bchd. This definitely works for others on testnet?
Only when running local bchd. Like:
bchd --testnet4 --whitelist 127.0.0.0/8 --whitelist ::1 --banduration=20s
buck54321
force-pushed
the
bchspv
branch
3 times, most recently
from
6f8e3c5
to
39c0708
Compare
Testing on simnet requires bchd and bchctl from gcash to be in PATH. client/asset/bch: Add bchSpvWallet type, which implements btc.BTCWallet around gcash/btcwallet. Most methods simply perform type translaction from the gcash types to the btcsuite types. Wallet creation is handled in-package. Wallet initalization is handled via a constructor passed to the (now-exported) btc.OpenSPVWallet. client/asset/btc: ConfigOpts that are common to clone assets can be generated with the new CommonConfigOpts, SPVConfigOpts, and RPCConfigOpts functions. OpenSPVWallet has been exported and modified to accept a constructor for a BTCWallet. Some spvWallet methods are now exported, including startWallet -> Start and signTransaction -> SignTx. dex: New ErrorCloser type handles a common pattern where itermediary instances of whatever need to be shut down if some sequence of actions doesn't complete successfully. Used in bch and btc. dex/testing/btc: Harness updated to allow running a bchd/bchwallet pair. These are needed for the compact filters.
|
I think I'll try mainnet, but the above is my a local bchd testnet4 node I just started fresh. |
On this issue, it does not seem to prevent bchd from syncing with the fork at https://tbch4.loping.net/, so I guess it's not fatal. The invalid fork seems to be tracked by https://testnet4.imaginary.cash/ |
There was a problem hiding this comment.
We really need this, and all of your code looks pristine, so we should move forward with it, but bchd and/or the bch-neutrino are really flaky in testing. I got into a situation with an active trade that took multiple restarts of both dexc and my local bchd, and multiple wallet Recover and Rescans to get it back in sync.
At some point dexc/neutrino or the one bchd peer got stuck:
2022-09-16 22:07:35.661 [WRN] CORE[bch][SPV][NTRNO]: Unable to fetch set of candidate checkpoints, trying again...
2022-09-16 22:07:48.662 [WRN] CORE[bch][SPV][NTRNO]: Unable to fetch set of candidate checkpoints, trying again...
2022-09-16 22:07:57.415 [DBG] CORE[dcr]: tip change: 993745 (00000000bf0208d4dec5e9265273c7034f46b6f0a2ddac1a4319d05a7744d571) => 993746 (000000006e2f32a0b01b1e0a93c213d225d608f02a3f96a3dfb3d3c53e3d04d2)
2022-09-16 22:07:57.415 [DBG] CORE[bch][SPV]: Performing cfilters scan for 2bb6fc26be13f4a6c5fe1600993eeef31c09d1594b8265169840760f50edb452:0 from height 113250
2022-09-16 22:07:57.416 [DBG] CORE[bch][SPV]: Performing cfilters scan for 2bb6fc26be13f4a6c5fe1600993eeef31c09d1594b8265169840760f50edb452:0 from height 113250
2022-09-16 22:08:01.663 [WRN] CORE[bch][SPV][NTRNO]: Unable to fetch set of candidate checkpoints, trying again...
2022-09-16 22:08:14.664 [WRN] CORE[bch][SPV][NTRNO]: Unable to fetch set of candidate checkpoints, trying again...
2022-09-16 22:08:27.666 [WRN] CORE[bch][SPV][NTRNO]: Unable to fetch set of candidate checkpoints, trying again...
2022-09-16 22:08:30.953 [DBG] CORE: Unsubscribing from the dcr_bch order book for dex-test.ssgen.io:7232
2022-09-16 22:08:40.668 [WRN] CORE[bch][SPV][NTRNO]: Unable to fetch set of candidate checkpoints, trying again...
2022-09-16 22:08:53.670 [WRN] CORE[bch][SPV][NTRNO]: Unable to fetch set of candidate checkpoints, trying again...
2022-09-16 22:09:06.672 [WRN] CORE[bch][SPV][NTRNO]: Unable to fetch set of candidate checkpoints, trying again...
2022-09-16 22:09:19.673 [WRN] CORE[bch][SPV][NTRNO]: Unable to fetch set of candidate checkpoints, trying again...
^C2022-09-16 22:09:24.462 [INF] DEXC: Attempting to logout...
You have active orders. Shutting down now may result in failed swaps and account penalization.
Do you want to quit anyway? ('yes' to quit, or enter to abort shutdown): y
2022-09-16 22:09:25.487 [INF] DEXC: Shutting down...
2022-09-16 22:09:25.487 [INF] CORE[DB]: Backing up database...
2022-09-16 22:09:25.487 [DBG] CORE: notify: |POKE| (conn) Server disconnect - dex-test.ssgen.io:7232 is disconnected
2022-09-16 22:09:25.487 [DBG] CORE[wss://dex-test.ssgen.io:7232/ws]: Sending close 1000 (normal) message.
2022-09-16 22:09:25.487 [INF] WEB: Web server off
2022-09-16 22:09:25.488 [WRN] CORE: Shutting down with active order d815f3cbcb71bd9e71382d47eba857d72ede2495b5dea3516b77ae0855373d5f in status executed.
2022-09-16 22:09:25.488 [WRN] CORE: Shutting down with active order 958cd74322f9baabb0970057d95a012e9a8995ae9e1cbd981cfd0b7171080686 in status executed.
2022-09-16 22:09:25.488 [INF] CORE: Locking DCR wallet
2022-09-16 22:09:25.488 [INF] CORE[dcr][SPV]: Unloading wallet
2022-09-16 22:09:25.489 [INF] CORE[dcr][SPV]: SPV wallet closed
2022-09-16 22:09:25.489 [INF] CORE: Locking BCH wallet
2022-09-16 22:09:25.489 [INF] CORE[bch][SPV]: Unloading wallet
2022-09-16 22:09:32.675 [WRN] CORE[bch][SPV][NTRNO]: Unable to fetch set of candidate checkpoints, trying again...
2022-09-16 22:09:32.676 [INF] CORE[bch][SPV]: SPV wallet closed
2022-09-16 22:09:32.676 [INF] CORE: DEX client core off
2022-09-16 22:09:32.676 [INF] DEXC: Exiting dexc main.
On restart of dexc, it continued with those Unable to fetch set of candidate checkpoints, trying again...
So then I tried another restart, but same. Then I tried a Rescan, which didn't seem to work right, and then a Recover.
Restarted my bchd twice, then restarted dexc, before it was able to start serving to neutrino again. There was nothing in bchd logs to indicate an issue however. I did notice that sometimes on bchd startup it would be lacking messages like [INF] PEER: Growing size of checkpoint cache from 52 to 54 block hashes, and if it did have them it seemed to be alright.
|
Oh all that weirdness in my last comment started when I noticed an order funded by a split tx timed out during placement, because it didn't propagate because either neutrino or bchd choked at some point prior. |
The gcash repo has been replaced by a branch on my fork until my PRs get merged on gcash. Here is the diff.
There aren't any new unit tests, because the stuff that might be unit tested is really just type translations.
Testing on simnet requires bchd and bchctl from gcash to be in
PATH. The harness will start a bchd node if both are found.