server/asset/btc: recognize errNoFeeRate #1655
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server logs spam like this every epoch (with two DOGE markets):
This PR cools off the logs a bit by introducing
errNoFeeRate
to go along witherrNoCompetition
. TheerrNoFeeRate
is just used by the estimate fee methods when there's no error from the RPC, but the rate is zero. This leads to median fee estimation based on past blocks (or a cached rate) and is generally not an error condition.This also removes
btc.name
from many of the log statements inbtc.Backend
because the logger's prefix already contains the asset, e.g.[DBG] ASSET[doge]: Blocks are too empty to calculate median fees. Using no-competition rate (4000).