Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: restyle markets page #1825

Merged
merged 3 commits into from
Oct 3, 2022
Merged

ui: restyle markets page #1825

merged 3 commits into from
Oct 3, 2022

Conversation

buck54321
Copy link
Member

The markets page is restyled. The new style is responsive. There are also some other stylistic changes that apply across the app. Still need to do a little housekeeping and add some docs.

desktop

smaller

mobile

Copy link
Member

@JoeGruffins JoeGruffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. I can finally trade on my phone. Looks amazing.

@chappjc chappjc self-requested a review September 14, 2022 14:46
Copy link
Member

@chappjc chappjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should get #1663 in first if you don't mind. EDIT: Done.

This PR is probably the best time to design for a (much much smaller) recent matches table, perhaps even hideable, that looks like the ones on trex and bn that I linked to on that PR.

client/webserver/locales/pl-pl.go Show resolved Hide resolved
client/webserver/site/src/js/locales.ts Show resolved Hide resolved
client/webserver/site/src/css/main.scss Show resolved Hide resolved
@buck54321
Copy link
Member Author

buck54321 commented Sep 21, 2022

I have a little work left to do on the recent matches section and I'll address review comments too.

Copy link
Member

@chappjc chappjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Just a silly conflict with a candles change to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants