multi: bring upstream fixes for force closures after reconnection #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous behavior would allow updates to be overwritten in some scenarios. Upon restart, this would lead to a missing settle/fail in the update logs.
Without this, calls to DisconnectPeer would bypass the peerTerminationWatcher and allow subsequent connect requests to go through before the peer's links were fully shut down. This could lead to force closes.
(matheusd): This was adapted to move the diff from lnd_switch_test.go to lnd_test.go as that test was not moved yet in this history.
Now that disconnection takes longer, this test also needs fixing.
matheusd
force-pushed
the
bring-close-fixes
branch
from
47b98d2 to
12067f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the following upstream PRs to fix issues with force closed channels after peer reconnections:
lightningnetwork#4915
lightningnetwork#5231
lightningnetwork#6655