Add new balancetomaintain rpc command #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlyp
force-pushed
the
ayp_balancetomaintain
branch
from
dab3bd0
to
04235d1
Compare
|
The help needs to be added for these commands. |
|
Also needs a rebase. |
|
Code looks good, need my node to catch up then I'll test. |
|
jcv@triforce tmp $ dcrctl --testnet --wallet setbalancetomaintain 1.1 Are those using different units? If so, should probably make them use the same. |
alexlyp
force-pushed
the
ayp_balancetomaintain
branch
from
74675ff
to
f194f83
Compare
|
That takes care of the output and help. It does need some bounds checking though: jcv@triforce tmp $ dcrctl --testnet --wallet setbalancetomaintain 1000000000000000000000000000000 |
alexlyp
force-pushed
the
ayp_balancetomaintain
branch
from
e659d6b
to
1f6658d
Compare
alexlyp
force-pushed
the
ayp_balancetomaintain
branch
from
ed34b6d
to
72ac490
Compare
|
tACK |
Restrict access to balanceToMaintain to only new get/set funcs
alexlyp
force-pushed
the
ayp_balancetomaintain
branch
from
db102af
to
045a934
Compare
beansgum
pushed a commit
to beansgum/dcrwallet
that referenced
this pull request
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will now allow users to update balancetomaintain while wallet is running.
Also make balanceToMaintain into unexported and restrict access to normal get/setters.