Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix address pool panics on start up #143

Merged
merged 2 commits into from
Apr 1, 2016
Merged

Fix address pool panics on start up #143

merged 2 commits into from
Apr 1, 2016

Conversation

cjepson
Copy link
Contributor

@cjepson cjepson commented Mar 31, 2016 

Add safety checks for address pool access

Address pool access now has checks to ensure that the address
pool exists and has been initialized before calls accessing its
functions or internals.

@cjepson cjepson changed the title Cj 310316addrpoolpanic Fix address pool panics on start up Mar 31, 2016
alexlyp
alexlyp reviewed Mar 31, 2016
View reviewed changes
wallet/addresspool.go
// mutexes.
func (w *Wallet) CheckAddressPoolsInitialized(account uint32) error {
if w.addrPools[waddrmgr.DefaultAccountNum] == nil {
return fmt.Errorf("Address pools for account %v"+
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need an extra whitespace here

@alexlyp
Copy link
Member

alexlyp commented Mar 31, 2016

looks like CheckAddressPoolsInitialized should be using account not DefaultAccoutnNum

@jcvernaleo
Copy link
Member

Other than the missing space @alexlyp mentioned, this works for me too.
tACK

@cjepson
Modify the logic for password prompting
5141dfa 
Password prompting on first run or when --promptpass has been
set now prompts before the RPC server has started. If the wrong
password is entered, the user is reprompted to enter their
password.

Automatic prompt for password on stake mining being enabled was
also removed.
@cjepson
Add safety checks for address pool access
125bbdd 
Address pool access now has checks to ensure that the address
pool exists and has been initialized before calls accessing its
functions or internals.
@cjepson
Copy link
Contributor Author

cjepson commented Apr 1, 2016

Ok, update

@jcvernaleo
Copy link
Member

OK this one is good to go too.

@jcvernaleo jcvernaleo merged commit 125bbdd into decred:master Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjepson @alexlyp @jcvernaleo