Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wallet flag for allowhighfees #214

Merged
merged 1 commit into from
May 3, 2016
Merged

Add wallet flag for allowhighfees #214

merged 1 commit into from
May 3, 2016

Conversation

alexlyp
Copy link
Member

@alexlyp alexlyp commented Apr 26, 2016

No description provided.

@raedah raedah mentioned this pull request Apr 28, 2016
Merged
@cjepson
Copy link
Contributor

cjepson commented May 3, 2016 •
edited
Loading

It looks like a number of calls to SendRawTransaction were missed.

grep -rsn "SendRawTransaction"
rpc/legacyrpc/methods.go:2985: txSha, err := chainClient.SendRawTransaction(createdTx.MsgTx, false)
rpc/legacyrpc/methods.go:3066: txSha, err := chainClient.SendRawTransaction(createdTx.MsgTx, false)
rpc/legacyrpc/methods.go:3597: hash, err := chainClient.SendRawTransaction(msgTx, false)
wstakemgr/stake.go:644:// SendRawTransaction sends a raw transaction using the chainSvr.
wstakemgr/stake.go:647:func (s _StakeStore) SendRawTransaction(msgTx *wire.MsgTx) (_chainhash.Hash,
wstakemgr/stake.go:655: return s.chainSvr.SendRawTransaction(msgTx, false)
wstakemgr/stake.go:893: ssgenSha, err := s.chainSvr.SendRawTransaction(msgTx, false)
wstakemgr/stake.go:981:// submits it by SendRawTransaction. It also stores a record of it
wstakemgr/stake.go:1082: ssrtxSha, err := s.chainSvr.SendRawTransaction(msgTx, false)

RPC server should access wallet to get the variable. Not sure about the stake manager, you could pass a global for that package.

@cjepson
Copy link
Contributor

cjepson commented May 3, 2016

tACK On simnet, let me review the code

cjepson
cjepson reviewed May 3, 2016
View reviewed changes
config.go
@@ -93,6 +94,7 @@ type config struct {
PoolFees float64 `long:"poolfees" description:"The per-ticket fee mandated by the ticket pool as a percent (e.g. 1.00 for 1.00% fee)"`
AddrIdxScanLen int `long:"addridxscanlen" description:"The width of the scan for last used addresses on wallet restore and start up (default: 750)"`
StakePoolColdExtKey string `long:"stakepoolcoldextkey" description:"Enables the wallet as a stake pool with an extended key in the format of \"xpub...:index\" to derive cold wallet addresses to send fees to"`
AllowHighFees bool `long:"allowhighfees" description:"Force dcrd to allow highfees from all sendrawtransaction"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually the RPC client doing this. Maybe "Force the RPC client to use the 'allowHighFees' flag when sending transactions'

@cjepson
Copy link
Contributor

cjepson commented May 3, 2016

Fix those issues and OK to squash and merge

@cjepson
Copy link
Contributor

cjepson commented May 3, 2016 •
edited
Loading

Also please add a detailed description in the commit (what was broken, what you added and why that fixed it).

@alexlyp
Add wallet flag for allowhighfees
ec2c1c2 
In the past there was no way to set the SendRawTransaction AllowHighFees
options without changing code.  This option lets users force their
transactions to go through without having to be checked according to the
high fees check in mempool.go in dcrd.  Now users can set this flag on
start up and all transactions will be excepted no matter how fee their
fee is.  (Though obviously the low end fee check will still be in place,
this only applies to high fees)
@jcvernaleo
Copy link
Member

Looks like all was taken care of.
OK

@jcvernaleo jcvernaleo merged commit ec2c1c2 into decred:master May 3, 2016
@alexlyp alexlyp deleted the ayp_allowhighfees branch May 27, 2016 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexlyp @cjepson @jcvernaleo