Enable vendor experiment earlier in travis script. #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the vendor experiment is enabled when building not just dcrwallet, but glide itself as well (glide vendors dependencies and checks them into its git repo). While here, switch from using 'go get $(glide novendor)' to 'go install . ./cmd/...' to build the project and all related commands. This won't hide errors when glide fails to restore a required dependency or the vendor experiment is disabled.
|
Looks good. |
|
kk i'll get this in then rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the vendor experiment is enabled when building not
just dcrwallet, but glide itself as well (glide vendors dependencies
and checks them into its git repo).
While here, switch from using 'go get $(glide novendor)' to 'go
install . ./cmd/...' to build the project and all related commands.
This won't hide errors when glide fails to restore a required
dependency or the vendor experiment is disabled.