Attempt to streamline getting/setting of fees for main/testnet #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it. Not repeating that switch/case so many times seems like a positive to me. |
| @@ -225,7 +216,8 @@ func newWallet(vb uint16, esm bool, btm dcrutil.Amount, addressReuse bool, | |||
| BalanceToMaintain: btm, | |||
| CurrentStakeDiff: &StakeDifficultyInfo{nil, -1, -1}, | |||
| lockedOutpoints: map[wire.OutPoint]struct{}{}, | |||
| feeIncrement: feeIncrement, | |||
| feeIncrementMainnet: FeeIncrementMainnet, | |||
There was a problem hiding this comment.
You should just declare a single fee increment here, since mainnet and testnet will never be enabled at the same time. Put the switch case above the struct declaration.
|
Seems good when I run it. |
Remove all switch/cases for FeeIncrment except for intial wallet creation. Instead all set/getting of feeIncrement is done with the mutex safe get and set. This cleans up the code and provides a straightforward way to get/set that field
alexlyp
force-pushed
the
ayp_cleanSwitchs
branch
from
e0ffc37
to
ee276f6
Compare
|
Tested and it is good. OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move switch/case for main/testnet inside the get/setters for wallet.FeeIncrement()
Replace all existing switch/cases with w.FeeIncrement() and the proper one will be returned.
On wallet creation the 2 non-exported feeIncrementMainnet and feeIncrementTestnet fields in wallet are set to the consts FeeIncrementMainnet and FeeIncrementTestnet respectively.
Fixes #34