Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More realistic fake.InMemorySnapshot #263

Merged
merged 3 commits into from
Aug 14, 2023
Merged

More realistic fake.InMemorySnapshot #263

merged 3 commits into from
Aug 14, 2023

Conversation

pierluca
Copy link
Contributor

@pierluca pierluca commented Aug 8, 2023

Some tests were becoming hard to write with the super-simple fake InMemorySnapshot.
This should make things easier, but carries the risk of breaking things.
This draft PR was created to let the CI scream at us while we proceed with other developments.

@pierluca pierluca requested a review from jbsv August 8, 2023 06:40
@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

62.9% 62.9% Coverage
2.2% 2.2% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5857606952

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 98.714%
Files with Coverage Reduction New Missed Lines %
mino/minogrpc/server.go 2 99.33%
Totals Coverage Status
Change from base Build 5832016077: -0.007%
Covered Lines: 14666
Relevant Lines: 14857
💛 - Coveralls

@pierluca pierluca marked this pull request as ready for review August 14, 2023 15:35
jbsv
jbsv approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@jbsv jbsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbsv jbsv merged commit 02ee68c into access_prefix Aug 14, 2023
7 checks passed
@jbsv jbsv deleted the inmemory_store branch August 14, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbsv jbsv jbsv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierluca @coveralls @jbsv