Minor changes #275
Closed
Minor changes #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineiti
force-pushed
the
minor_changes
branch
from
6b0c05d
to
ed17aae
Compare
|
Hmm - because I don't have the |
This commit fixes one test and makes two types of tests: - 'go test -short' runs only the non-flaky tests - then the flaky tests are run 3 times, and should pass at least once
This PR includes mostly changed comments and some corrections to the documentation.
ineiti
force-pushed
the
minor_changes
branch
from
ed17aae
to
5471a1f
Compare
pierluca
reviewed
Sep 1, 2024
There was a problem hiding this comment.
Is this really simpler than addressing the underlying causes of the test flakiness ? :-/
I tend to get a little worried when I start seeing things like this in the Makefile 😅
There was a problem hiding this comment.
This work is left as an exercise to the reader...
Yes, it would be better, but I did spend quite some time on getting the tests to run, and after some time I didn't advance, so I came up with this, which is in fact a copy of what I did for some tests in the cothority :)
|
Closing this for the new PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes mostly changed comments and some corrections to the documentation.