Fix tls #282
Merged
Fix tls #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes one test and makes two types of tests: - 'go test -short' runs only the non-flaky tests - then the flaky tests are run 3 times, and should pass at least once
This PR includes mostly changed comments and some corrections to the documentation.
For the d-voting, the current timeouts are way to short. This puts more reasonable timeouts, and allows the tests to set shorter timeouts.
This is a very important fix for the blockstore module. Without it, only 255 blocks can be stored.
This commit changes the address format of the nodes, to disambiguate between the grpc over http, over self-signed certificates, and grpc over public-CA signed certificates.
Merge back tls
|
IIRC I worked on the tests quite a lot - some of them failed in newer golang versions, other were very flaky. There is more than one commit wrt tests in c4dt/dela... |
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.