optimize chain #283
Closed
optimize chain #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PascalinDe
commented
Apr 3, 2024
PascalinDe
commented
- add fastsync protocol
- fix comparisons/updates of block indices and nonces
Use RandomFilter to select a given amount of indexes randomly. Added suggestion from @PascalinDe
Adds the fastsync as default protocol to cosipbft. Adds a 'WithBlockSync' option for the old, slow protocol. Updates all the tests.
Adding a fast synchronisation protocol
- increased the default timeouts (tests set their own timeout) - increased maximum message size over grpc
Using main for github workflow
Updating the timeouts to make pass 1000 votes
E2e fixes
Don't use the sync beforehand - the manager.Make takes care of that
|
@ineiti I wasn't sure how to split this up in smaller PRs as they seem to more or less revolve around the same issue (syncing) with maybe one or two commits that address some other issue, I let you split this up more sensibly if need be |
ineiti
requested changes
Apr 8, 2024
There was a problem hiding this comment.
Just one comment that needs to be removed - @PascalinDe do you want to patch the commit? Or shall I do it?
| @@ -2,7 +2,7 @@ name: Go lint | |||
|
|
|||
| on: | |||
| push: | |||
| branches: [ master ] | |||
| branches: [ main ] | |||
There was a problem hiding this comment.
@pierluca @jbsv - not sure if you want to switch to main branch instead of master. We switched all our repos to main: https://www.theserverside.com/feature/Why-GitHub-renamed-its-master-branch-to-main
Comment on lines
+87
to
+88
| // LG: DEBUG - I'd like to keep this commented line, as it helps debugging. | ||
| // res.Message = fmt.Sprintf("%+v", err) |
There was a problem hiding this comment.
@ineiti TODO: need to remove these lines...
|
Closed in favor of #285 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.