permission should run on all platforms #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔒 Could not start CI tests due to missing safe PR label. Please contact one of the repo maintainers. |
pierluca
reviewed
Nov 25, 2022
.github/workflows/go_tests.yml
Outdated
| @@ -28,13 +33,9 @@ jobs: | |||
| echo "::error:: Could not start CI tests due to missing *safe PR* label." | |||
| exit 1 | |||
|
|
|||
| test: | |||
| coverage: | |||
There was a problem hiding this comment.
Maybe for clarity
Suggested change
| coverage: | |
| test_and_coverage: |
.github/workflows/go_tests.yml
Outdated
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| platform: [ubuntu-latest, macos-latest, windows-latest] |
There was a problem hiding this comment.
won't this lead to 3 comments being added to the PR ?
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it may happen that the job runs on windows or macos, before the permission job has run on ubuntu, which leads to a failed CI, even though the 'safe PR' label has been set.
This PR aims to correct this behaviour.