Curve renaming #528
Merged
Curve renaming #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnomalRoil
requested changes
Jun 5, 2024
AnomalRoil
reviewed
Jun 5, 2024
| @@ -10,7 +10,7 @@ | |||
| // are isomorphic to curves having c == 1. | |||
| // | |||
| // For details see Bernstein et al, "Twisted Edwards Curves", http://eprint.iacr.org/2008/013.pdf | |||
| package curve25519 | |||
| package var_ed25519 | |||
There was a problem hiding this comment.
Need to change package comment on line 1 here.
There was a problem hiding this comment.
Also renaming below "func Param25519() *Param" to "func ParamEd25519() *Param" might be best.
group/p256/doc.go
Outdated
| @@ -1,3 +1,3 @@ | |||
| // Package nist implements cryptographic groups and ciphersuites | |||
There was a problem hiding this comment.
need to change package level comment here
AnomalRoil
reviewed
Jun 5, 2024
AnomalRoil
reviewed
Jun 5, 2024
AnomalRoil
requested changes
Jun 6, 2024
group/var_ed25519/curve.go
Outdated
Comment on lines
70
to
72
| // NewKey returns a formatted curve25519 key (avoiding subgroup attack by requiring | ||
| // NewKey returns a formatted var_ed25519 key (avoiding subgroup attack by requiring | ||
| // it to be a multiple of 8). NewKey implements the kyber/util/key.Generator interface. | ||
| func (c *curve) NewKey(stream cipher.Stream) kyber.Scalar { |
There was a problem hiding this comment.
There was a problem hiding this comment.
maybe returns a scalar suitable for use as a secret key instead of naming the curve @matteosz?
|
Please retry analysis of this Pull-Request directly on SonarCloud |
AnomalRoil
approved these changes
Jun 6, 2024
|
This was referenced Jul 15, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses partially #384, by:
For a future PR we could add the curve25519 (Montgomery representation).