Bugfix/3.4 renderer clipping and crash fix #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanr
added
bug
|
The deegree 3.3 Line is not affacted because all Geometries will be clipped [1]. |
stephanr
force-pushed
the
bugfix/3.4-renderer-clipping-and-crash-fix
branch
from
04a390f
to
ac2143d
Compare
tfr42
added
tests failing
|
On the TMC meeting we discussed that, See also #645 |
add a constraint to dasharray/perpendicularOffset to the GenerationExpensive decision as it can create hung processes or jvm crashes on extreme geometries
stephanr
force-pushed
the
bugfix/3.4-renderer-clipping-and-crash-fix
branch
from
ac2143d
to
4f443c8
Compare
|
I had rebased the pull request and applied a workaround for CW/CCW oriented polygons so they are not reorientated anymore. |
copierrj
added a commit
that referenced
this pull request
Dec 22, 2015
…d-crash-fix Bugfix/3.4 renderer clipping and crash fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Bugfix fixes the Polygon rendering of clipped Polygons and also extends the logic of clipping for circumstances to be more robust.
I also moved the clipping decision methods to the GeometryClipper to be easier readable.
Currently if a stroke contains a dasharray an a logical defect geometry (for example one point a million meter away from the rest of the points) the jdk renderer will either consume a extrem large ammount of time or in the worst case the jdk will crash.
As this situation is extreamly annoying i also created a testcase to prevent the clipper from missing this situation.
(So for example if the patch would be reversed the JUnit Testcase will catch the timeout and fail)