Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in sld_body request parameter #524

Merged
merged 1 commit into from
Oct 1, 2015

Conversation

dstenger
Copy link
Contributor

The request parameter "SLD_BODY" did not work as the style/filter/layer maps in RequestBase were never filled when parsing the sld. This fix enables the filling of those maps.

This pull request was also created for the master (#523).

@dstenger dstenger added the bug error issue and bug (fix) label Apr 16, 2015
@MrSnyder MrSnyder added this to the 3.3.15 milestone Apr 30, 2015
@MrSnyder
Copy link
Contributor

Thank you for your contribution. However, we found that it is not ready yet for inclusion:

  • We need more information when this issue occurs
  • What is the context?
    • Please provide information on the current behavior and the expected behavior.
    • Can you please provide a request which does not work without that fix and works with that fix

The TMC would be happy if you can find the time to address these shortcomings.

@tfr42 tfr42 added the needs discussion requires discussion with contributor label Apr 30, 2015
@tfr42 tfr42 self-assigned this Apr 30, 2015
@tfr42 tfr42 modified the milestones: 3.3.16, 3.3.15 Apr 30, 2015
@tfr42
Copy link
Member

tfr42 commented Apr 30, 2015

Moved to 3.3.16

@ghost
Copy link

ghost commented May 5, 2015

This issue occurs in every deegree webservices version between 3.2 and this fix.
The current behaviour is, that requests such as:
http://yourfavoritesite.com/WMS?
REQUEST=GetMap&
BBOX=0.0,0.0,1.0,1.0&
SLD=http%3A%2F%2Fmyclientsite.com%2FmySLD.xml&
WIDTH=400&
HEIGHT=400&
FORMAT=PNG

or

http://yourfavoritesite.com/WMS?
REQUEST=GetMap&
BBOX=0.0,0.0,1.0,1.0&
SLD_BODY=%3C%3Fxml+version%3D%221.0%22+encoding%3D%22UTF-8%22%3F%3E%3CStyled
LayerDescriptor+version%3D%221.1.0%22%3E%3CNamedLayer%3E%3CName%3ERivers%3C%2FN
ame%3E%3CNamedStyle%3E%3CName%3ECenterLine%3C%2FName%3E%3C%2FNamedStyle%3E%3C%2
FNamedLayer%3E%3CNamedLayer%3E%3CName%3ERoads%3C%2FName%3E%3CNamedStyle%3E%3CNa
me%3ECenterLine%3C%2FName%3E%3C%2FNamedStyle%3E%3C%2FNamedLayer%3E%3CNamedLayer
%3E%3CName%3EHouses%3C%2FName%3E%3CNamedStyle%3E%3CName%3EOutline%3C%2FName%3E%
3C%2FNamedStyle%3E%3C%2FNamedLayer%3E%3C%2FStyledLayerDescriptor%3E
WIDTH=400&
HEIGHT=400&
FORMAT=PNG

are processed while ignoring the sld parameters like SLD_BODY.
This means, that using the sld parameters given by the OGC SLD specification did never work in the mentioned versions.
The final result of that fix is, that now the sld parameters are used to style the features of the requested layers instead of doing nothing.

copierrj added a commit that referenced this pull request Oct 1, 2015
Fixed bug in sld_body request parameter
@copierrj copierrj merged commit 88237ce into deegree:3.3-master Oct 1, 2015
@copierrj
Copy link
Member

copierrj commented Oct 1, 2015

See: #606

@tfr42 tfr42 removed the needs discussion requires discussion with contributor label Oct 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug error issue and bug (fix)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants