Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #848 - new [SQLFeatureStore] Deleting features fails for certain feature type prefix configurations #867

Merged
merged 12 commits into from
Feb 16, 2018

Conversation

nitram509
Copy link
Contributor

Hi,

this PR supersedes #850.
It reduces the PR to the actual changed files and relevant commits.

Fore actual content details, please have a look at #850

Regards
Martin

nitram509 and others added 12 commits October 2, 2017 23:50
…ertain feature type prefix configurations

Reason: when searching features by prefixes, one need to make sure,
the list to be searched is sorted. Else, a prefix named 'p' will wrongly
return a feature 'ppFeatureName'. The test shows a concrete example.
incl. renaming test class (ArrayUtilsTest), to match class under test name
…efore oraclejdk7 build disabled until we switch to Oracle JDK 8 which is supported by travis-ci.

(cherry picked from commit 506b075)
…ertain feature type prefix configurations

Reason: when searching features by prefixes, one need to make sure,
the list to be searched is sorted. Else, a prefix named 'p' will wrongly
return a feature 'ppFeatureName'. The test shows a concrete example.
incl. renaming test class (ArrayUtilsTest), to match class under test name
- $HOME/.m2/repository/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove this change!

@copierrj
Copy link
Member

Thank you for your contribution. The TMC meeting noticed that your PR contains a change to the .travis.yml file. It was therefore decided that we would to ask you if you can remove this change.

@nitram509
Copy link
Contributor Author

@tfr42 sure, I'm willing to support and follow your advice.
BUT: I hesitate to do it, because I believe there is a miss-understanding.

This change was introduced 9/Feb/2015 and I did not touched/changed this line. I did merge from MASTER and there you can see, this change is in.
I believe there is a visualization issue in the Github Web-UI, which wrongly shows that I have added this line - which is not the case.

Indeed, I removed a line from .travis.ml

dist: precise
(according to comment in #850).

Would you please double check and confirm,
that I should remove the caching configuration for the Maven repo-folder?

@tfr42
Copy link
Member

tfr42 commented Feb 16, 2018

Would you please double check and confirm,

Looks ok. It seems to be a CR/LF character issue.

that I should remove the caching configuration for the Maven repo-folder?

No, please leave it as it is.

@copierrj copierrj merged commit bff62a1 into deegree:master Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug error issue and bug (fix) WFS deegree Web Feature Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants