Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various chords & maintenance duties. #121

Merged
merged 8 commits into from
Jan 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/rust-clippy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
continue-on-error: false

- name: Upload analysis results to GitHub
uses: github/codeql-action/upload-sarif@v2
uses: github/codeql-action/upload-sarif@v3
with:
sarif_file: rust-clippy-results.sarif
wait-for-processing: true
66 changes: 0 additions & 66 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,69 +24,3 @@ codegen-units = 1 # Reduce Parallel Code Generation Units to Increase Optimizati
opt-level = 3
strip = true # Automatically strip debug symbols from the binary to reduce size
codegen-units = 1 # Reduce Parallel Code Generation Units to Increase Optimization


[lints]
# https://internals.rust-lang.org/t/proposal-cargo-lint-configuration/9135
# https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#lints
#
# Deny lints largely due to future incompabilities
ambiguous_glob_imports = "deny"
coherence-leak-check = "deny"
coinductive-overlap-in-coherence = "deny"
const_evaluatable_unchecked = "deny"
const_item_mutation = "deny"
const_patterns_without_partial_eq = "deny"
deref_nullptr = "deny"
elided_lifetimes_in_associated_constant = "deny"
for_loops_over_fallibles = "deny"
illegal_floating_point_literal_pattern = "deny"
indirect_structural_match = "deny"
invalid_doc_attributes = "deny"
invalid_nan_comparisons = "deny"
invalid_value = "deny"
irrefutable_let_patterns = "deny"
late_bound_lifetime_arguments = "deny"
non_fmt_panics = "deny"
overlapping_range_endpoints = "deny"
repr_transparent_external_private_fields = "deny"
semicolon_in_expressions_from_macros = "deny"
special_module_name = "deny"
trivial_bounds = "deny"
type_alias_bounds = "deny"
unconditional_recursion = "deny"
uninhabited_static = "deny"
unstable_name_collisions = "deny"
where_clauses_object_safety = "deny"

# Warning lints
deprecated_where_clause_location = "warning"
deref_into_dyn_supertrait = "warning"
dropping_copy_types = "warning"
dropping_references = "warning"
duplicate_macro_attributes = "warning"
dyn_drop = "warning"
ellipsis_inclusive_range_patterns = "warning"
exported_private_dependencies = "warning"
forgetting_copy_types = "warning"
forgetting_references = "warning"
function_item_references = "warning"
hidden_glob_reexports = "warning"
inline_no_sanitize = "warning"
invalid_from_utf8 = "warning"
invalid_macro_export_arguments = "warning"
large_assignments = "warning"
legacy_derive_helpers = "warning"
map_unit_fn = "warning"
named_arguments_used_positionally = "warning"
non_shorthand_field_patterns = "warning"
noop_method_call = "warning"
path_statements = "warning"
private_interfaces = "warning"
unnameable_test_items = "warning"
unreachable_code = "warning"
unused_allocation = "warning"
unused_assignments = "warning"
unused_labels = "warning"
unused_macros = "warning"
while_true = "warning"
4 changes: 2 additions & 2 deletions dcl_data_structures/tests/window_array_backed_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ fn test_vec() {
assert_eq!(v.len(), SIZE);

let e1 = window.first().unwrap();
let v1 = v.get(0).unwrap();
let v1 = v.first().unwrap();
assert_eq!(e1.dats, v1.dats);

let e2 = window.last().unwrap();
Expand Down Expand Up @@ -289,7 +289,7 @@ fn test_arr() {
assert_eq!(arr.len(), SIZE);

let e1 = window.first().unwrap();
let a1 = arr.get(0).unwrap();
let a1 = arr.first().unwrap();
assert_eq!(e1.dats, a1.dats);

let e2 = window.last().unwrap();
Expand Down
4 changes: 2 additions & 2 deletions dcl_data_structures/tests/window_vector_backed_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ fn test_vec() {
assert_eq!(v.len(), SIZE);

let e1 = window.first().unwrap();
let v1 = v.get(0).unwrap();
let v1 = v.first().unwrap();
assert_eq!(e1.dats, v1.dats);

let e2 = window.last().unwrap();
Expand Down Expand Up @@ -284,7 +284,7 @@ fn test_arr() {
assert_eq!(arr.len(), SIZE);

let e1 = window.first().unwrap();
let a1 = arr.get(0).unwrap();
let a1 = arr.first().unwrap();
assert_eq!(e1.dats, a1.dats);

let e2 = window.last().unwrap();
Expand Down
4 changes: 2 additions & 2 deletions ultragraph/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ version = "^0.4"


[dependencies]
ahash = "^0.8"
petgraph = "^0.6"
ahash = "0.8"
petgraph = "0.6"


[dev-dependencies]
Expand Down
Loading