Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added & implemented Indexable trait for Context; #125

Merged
merged 5 commits into from
Jan 25, 2024

Conversation

marvin-hansen
Copy link
Member

Describe your changes

  • Added Indexable trait ;
  • Implemented Indexable trait for Context;
  • Documented all protocols / traits in deep causality crate

Code checklist before requesting a review

  • I have signed the DCO?
  • All tests are passing when running make test?
  • No errors or security vulnerabilities are reported by make check?

For details on make, please see BUILD.md

Note: The CI runs all of the above and fixing things before they hit CI speeds
up the review and merge process. Thank you.

Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
@marvin-hansen marvin-hansen self-assigned this Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (7b91bd8) 88.22% compared to head (88a791f) 87.85%.
Report is 3 commits behind head on main.

Files Patch % Lines
...src/types/context_types/context_graph/indexable.rs 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   88.22%   87.85%   -0.38%     
==========================================
  Files         122      123       +1     
  Lines        3219     3235      +16     
==========================================
+ Hits         2840     2842       +2     
- Misses        379      393      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marvin-hansen marvin-hansen merged commit 344ac28 into deepcausality-rs:main Jan 25, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant