Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add text segmentation example #142

Merged
merged 33 commits into from
May 3, 2021
Merged

docs: add text segmentation example #142

merged 33 commits into from
May 3, 2021

Conversation

oboulant
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the Type: Documentation Documentation only changes label Mar 22, 2021
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #142 (0a9ccbe) into master (4ddef57) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files          40       40           
  Lines         979      979           
=======================================
  Hits          940      940           
  Misses         39       39           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ddef57...0a9ccbe. Read the comment docs.

@deepcharles
Copy link
Owner

I added the corrections I wanted. Check if that is ok with you.

@deepcharles
Copy link
Owner

I do not understand how Github can run the notebooks without us specifying that it needs scikit-learn

@oboulant
Copy link
Collaborator Author

@deepcharles I added the gram matrix representation. Ca you check if the final result is fine with you ?

@deepcharles
Copy link
Owner

Maybe we should open another PR to do those kind of tests. And revert all changes to the run-test gh action in that current PR.

@oboulant
Copy link
Collaborator Author

Maybe we should open another PR to do those kind of tests. And revert all changes to the run-test gh action in that current PR.

Yes, what I wanted to do as well ! Will proceed with the revert and creation of a new PR for tweaking run-test.yml !

@oboulant oboulant merged commit 83e6ada into master May 3, 2021
@oboulant oboulant deleted the example-text branch May 26, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Documentation only changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants