Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add tests in CI for windows python v3.9 #219

Merged
merged 3 commits into from
Oct 20, 2021

Conversation

oboulant
Copy link
Collaborator

@oboulant oboulant commented Oct 20, 2021

This PR

  • removes from .github/workflows/run-test.yml the explicit bypass of tests for Windows and Python v3.9. At some point in the past, we had to bypass those because Python v3.9 and Windows intersection could not setup correctly (tests could not run). Now, the intersection Windows x Python v3.9 seems more mature and tests can run
  • merges both .github/workflows/run-test.yml and .github/workflows/run-test-coverage.yml into a single .yml with two jobs

@github-actions github-actions bot added the Type: CI Changes to CI configuration files and scripts label Oct 20, 2021
@oboulant oboulant marked this pull request as draft October 20, 2021 09:45
@oboulant oboulant marked this pull request as ready for review October 20, 2021 09:57
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #219 (741ecce) into master (111bfe7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #219    +/-   ##
=======================================
  Coverage        0   0.00%            
=======================================
  Files           0      40    +40     
  Lines           0     973   +973     
=======================================
- Misses          0     973   +973     
Flag Coverage Δ
unittests 0.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ruptures/detection/kernelcpd.py 0.00% <0.00%> (ø)
src/ruptures/base.py 0.00% <0.00%> (ø)
src/ruptures/detection/pelt.py 0.00% <0.00%> (ø)
src/ruptures/metrics/hausdorff.py 0.00% <0.00%> (ø)
src/ruptures/metrics/randindex.py 0.00% <0.00%> (ø)
src/ruptures/metrics/hamming.py 0.00% <0.00%> (ø)
src/ruptures/datasets/__init__.py 0.00% <0.00%> (ø)
src/ruptures/costs/costrbf.py 0.00% <0.00%> (ø)
src/ruptures/detection/dynp.py 0.00% <0.00%> (ø)
src/ruptures/show/__init__.py 0.00% <0.00%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 111bfe7...741ecce. Read the comment docs.

Copy link
Owner

@deepcharles deepcharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oboulant oboulant merged commit d2d3097 into master Oct 20, 2021
@oboulant oboulant deleted the ci/add-windows-py39-tests branch October 20, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: CI Changes to CI configuration files and scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants