Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconfigure Deployment #1780

Closed
2 tasks done
umesh-timalsina opened this issue Jul 17, 2020 · 0 comments · Fixed by #1782
Closed
2 tasks done

Reconfigure Deployment #1780

umesh-timalsina opened this issue Jul 17, 2020 · 0 comments · Fixed by #1782
Assignees
@umesh-timalsina
Labels
deployment enhancement

Comments

@umesh-timalsina
Copy link
Contributor

umesh-timalsina commented Jul 17, 2020 •
edited
Loading

Checklist:

  • Looking at yaml-merge, the values in a list are not appened but overwritten when creating custom-docker-compose.yml. Replacing this with yq, and some changes to our compose files should fix recent issues we are having with deployment.
  • Change quickstart documentation with two docker files/ overwrite capabilities with one of the tools?
@umesh-timalsina umesh-timalsina self-assigned this Jul 17, 2020
@umesh-timalsina umesh-timalsina changed the title Replace yaml-merge in deploy-deepforge with yq Reconfigure Deployment Jul 17, 2020
umesh-timalsina added a commit that referenced this issue Jul 17, 2020
@umesh-timalsina
replace yaml-merge with yq, fix quickstart deployment docs. Closes #1780
cb5505a
@umesh-timalsina umesh-timalsina linked a pull request Jul 17, 2020 that will close this issue
replace yaml-merge with yq, fix quickstart deployment docs. Closes #1780 #1782
Merged
brollb pushed a commit that referenced this issue Jul 20, 2020
@umesh-timalsina
replace yaml-merge with yq, fix quickstart deployment docs. Closes #1780
ffe1500 
 (#1782)

* replace yaml-merge with yq, fix quickstart deployment docs. Closes #1780

* WIP- rephrase production-docker-compose.yml creation sentence

* Minor changes to quickstart docs, docker-compose, deploy-deepforge

1. Revert to docker-compose.yml with ${TOKEN_KEYS_DIR} mount
2. Remove NODE_ENV=default from docker-compose.yml and fix key removal
3. Change documentation quickstart with docker using docker-compose run

* WIP- remove NODE_ENV=production quickstrat docs

* WIP remove -e from docker quickstart tutorial
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@umesh-timalsina umesh-timalsina

Labels
deployment enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace yaml-merge with yq, fix quickstart deployment docs. Closes #1780 deepforge-dev/deepforge
1 participant
@umesh-timalsina