-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support For 3D Scatter Plots and Line Plots (Closes #1463) #1572
Conversation
1. Add support for 3DScatter and LinePlots. 2. Refactor PlotlyDescExtractor to incoroprate3D Subplots 3. Extract 3D plots data from backend_deepforge.py 4. Minor changes to ExectionIndexControl 5. Change plotly.min.js to new version (v1.52.3) 6. Other minor changes
Would you mind adding an example pipeline to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. A couple minor changes. There are a few parts where it might be a little more complicated and I suspect it could be simplified but it's not a huge deal.
I still need to test it out locally but as long as there are no surprises, we should be good to go after the two minor comments are addressed!
src/common/viz/FigureExtractor.js
Outdated
|
||
desc = { | ||
id: id, | ||
execId: execId, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice to reduce the code duplication between 2D and 3D plots. The only gotcha is that 3D plots don't support images. Maybe they could be refactored to add a method for the shared abstract base class in the metamodel and both could call it...
3DScatter
andLine
Plots.PlotlyDescExtractor
to incoroprate3D Subplotsbackend_deepforge.py
ExectionIndexControl
plotly.min.js
to new version (v1.52.3)