Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metadata parsing in FigureExtractor. Closes #1764. #1765

Merged
merged 5 commits into from
Jul 14, 2020
Merged

Fix metadata parsing in FigureExtractor. Closes #1764. #1765

merged 5 commits into from
Jul 14, 2020

Commits on Jul 14, 2020

  1. Fix metadata parsing in FigureExtractor. Closes #1764.

    @umesh-timalsina
    umesh-timalsina committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    e665539 View commit details
    Browse the repository at this point in the history

  2. refactor getting metadata children for a node to a function 

    1. Minor refactor of ordering of functions
    @umesh-timalsina
    umesh-timalsina committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    69a3bde View commit details
    Browse the repository at this point in the history

  3. Remove _metaNodesMap from references and address PR review 

    1. Remove _metaNodesMap from FigureExtractor
2. Use .find instead of .filter followed by .pop in getMetadataChildrenIds
    @umesh-timalsina
    umesh-timalsina committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    8b4210e View commit details
    Browse the repository at this point in the history

  4. Fix return value in getMetadataChildrenIds

    @umesh-timalsina
    umesh-timalsina committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    b745f36 View commit details
    Browse the repository at this point in the history

  5. WIP- eslint fix. Remove underscore(_)

    @umesh-timalsina
    umesh-timalsina committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    2863480 View commit details
    Browse the repository at this point in the history