-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ace with monaco editor (Closes #571) #1800
Conversation
this.logger = logger.fork('Widget'); | ||
MonacoLanguages = JSON.parse(MonacoLanguages); | ||
const DEFAULT_THEMES = ['vs-dark', 'vs', 'hc-black']; | ||
const DEFAULT_COLORS = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to the lack of submenu support and already exsiting context menu. My plan was to add a separate button. This which opens the existing contextmenu. These colors were used in #1746 for the button in the context menu.
TextEditorWidget = function (logger, container, config={}) { | ||
this.logger = logger.fork('Widget'); | ||
MonacoLanguages = JSON.parse(MonacoLanguages); | ||
const DEFAULT_THEMES = ['vs-dark', 'vs', 'hc-black']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice to have a couple more themes available. Maybe 5 or 6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/brijeshb42/monaco-themes. Similar to #1800 (comment). Which would be the best course?
Can you share the raw text before it is rendered? |
The raw text is the following:
|
Ah, I see. The first one is using underlines and other SGR parameters; it currently only supports colors and expected there to be only two options. This should be pretty easy fix but could be fixed in it's own PR. |
…-monaco-text-editor
I am marking this active. There is one issue left to sortout: Somehow, 2 editor workers are being assingned when viewing stdout in Also, following issues will stem and should be addressed after this is merged:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! If you can remove the console.log, it should be good to go!
This PR only is part one of the two needed to close #571. This Introduces Monaco Text Editor, which has support for a language server protocol. |
Checklist:
Apply Basic Changes to panels
LogViewer
OperationCodeEditor
OperationDepEditor
TabbedTextEditor
SerializeEditor
Add Support for different themes, via contextmenu
Add support for keybindings (Currently, Only VIM is supported, Emacs can be added on a later PR/issue)