Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed tmp dir used for arch validation. Fixes #929 #930

Merged
merged 13 commits into from
Dec 20, 2016

Conversation

brollb
Copy link
Contributor

@brollb brollb commented Dec 10, 2016

No description provided.

@brollb brollb added this to the v0.22.0 milestone Dec 10, 2016
@brollb brollb changed the title 929 arch validation not removing tmp dirs Removed tmp dir used for arch validation. Fixes #929 Dec 10, 2016
@brollb brollb force-pushed the 929-arch-validation-not-removing-tmp-dirs branch from 304add9 to 364d4e4 Compare December 20, 2016 04:16
@@ -98,8 +129,10 @@ describe('ValidateArchitecture', function () {
}
};
plugin.main((err, result) => {
console.log('finished!');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These logs should be removed then it should be good to go

@brollb brollb merged commit 7ccf8da into master Dec 20, 2016
@brollb brollb deleted the 929-arch-validation-not-removing-tmp-dirs branch December 20, 2016 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant